Re: [PATCH v7 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete node name regex update in conditional schema blocks.
--

--- Patch [1]: [PATCH v7 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 ---
commit 0690191fc4f385657c026eb25eb9afc4e79fffd4
Author: Loic Poulain <[email protected]>

dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635

This commit updates the pca963x binding to support 16 LED channels on the
pca9635. It gives pca9634 its own conditional block and sets the maximum
registry value to 15 unconditionally in the top-level node.

> diff --git a/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml b/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
> index 938d0e48fe51b..4fda602912f7a 100644
> --- a/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
> +++ b/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
> @@ -62,14 +62,14 @@ properties:
>        open-drain, newer chips to totem pole).
>  
>  patternProperties:
> -  "^led@[0-9a-f]+$":
> +  "^led@[0-9a-f]$":

[ ... ]

> @@ -88,7 +88,13 @@ allOf:
>            properties:
>              reg:
>                maximum: 3
> -    else:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - nxp,pca9634
> +    then:
>        patternProperties:
>          "^led@[0-9a-f]+$":
          ^^^^^^^^^^^^^^^^^^

[Severity: Medium]
The commit message states the node name regex was tightened from
^led@[0-9a-f]+$ to ^led@[0-9a-f]$, but it seems this was only applied to the
top-level patternProperties.

Does this conditional block in Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
also need to be updated to match the top-level regex?

Leaving it as ^led@[0-9a-f]+$ creates a mismatch, and there may be other
allOf conditional blocks (like the one for pca9632/pca9633) that were also
missed.

>            properties:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1