Re: [PATCH v7 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support
Krzysztof Kozlowski <[email protected]> Mon, 27 Jul 2026 10:36:31 +0200
| Newsgroups | org.kernel.vger.linux-leds,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 27/07/2026 10:24, Loic Poulain wrote: >>> compatible: >>> @@ -96,10 +136,16 @@ allOf: >>> - nxp,pca9634 >>> then: >>> patternProperties: >>> - "^led@[0-9a-f]+$": >>> + "^.*led@[0-9a-f]$": >> >> Why changing this? multi-led is below, so maybe you wanted to combine >> both? > > Yes, I wanted to combine them so that both multi-led@ and led@ nodes > have their reg property checked by this filter, while the multi-led@ > filter below only checks the reg property of its led@ subnodes, though > it may not very clear and also too permissive? Ah, I see now, damn YAML indentation. Code is not that readable, but looks fine. Best regards, Krzysztof