Re: [PATCH v4] dt-bindings: leds: lacie,ns2-leds: Convert to DT schema

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:
- [Low] Using `additionalProperties: { type: object }` at the root level in=
correctly restricts all unlisted parent properties to be objects, causing v=
alidation to fail for standard devicetree properties.
--

--- Patch [1]: [PATCH v4] dt-bindings: leds: lacie,ns2-leds: Convert to DT =
schema ---
commit e51c70e2c2a321d27514dfdacc4ab4b3fb805568
Author: Ninad Naik <[email protected]>

dt-bindings: leds: lacie,ns2-leds: Convert to DT schema

This commit converts the lacie,ns2-leds device tree binding from plain text
to YAML schema.

> diff --git a/Documentation/devicetree/bindings/leds/lacie,ns2-leds.yaml b=
/Documentation/devicetree/bindings/leds/lacie,ns2-leds.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/lacie,ns2-leds.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: lacie,ns2-leds
> +
> +additionalProperties:
> +  type: object
> +  $ref: common.yaml#
> +  unevaluatedProperties: false
> +
> +  description: Each child node represents a single LED

[Severity: Low]
By applying type: object to additionalProperties at the root level, will th=
is
incorrectly restrict standard unlisted parent properties (such as status or
pinctrl-0) to be objects?=20

If a standard string or array property is added to the node, it looks like
schema validation will fail. Should patternProperties be used here instead =
to
selectively match the child LED nodes?

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260728183945.1200=
[email protected]?part=3D1