Re: [PATCH v5 1/1] leds: st1202: Add hardware-accelerated blink support

On Tue, 2026-08-04 at 10:52 +0000, [email protected] wrote:
>=20
> New issues:
> - [High] Hardware-accelerated blink destructively alters the physical
> state of all other active LEDs by zeroing their PWM slots.
> - [Medium] Hardware blink overrides user-configured brightness by
> hardcoding maximum intensity.
> - [Medium] Updating LED brightness indiscriminately breaks an active
> hardware blink configuration.
>=20
> Pre-existing issues:
> - [High] The driver incorrectly assigns a sleeping function to the
> non-blocking `brightness_set` callback, causing 'scheduling while
> atomic' panics.
> - [High] Dangling `fwnode` pointers due to un-incremented scoped
> device node reference.
> --

All five findings are either previously answered or already tracked for
a follow-up submission, as they are not directly related to the feature
this patch implements.

Unless there are any other reviewer comments, there will not be a v6.

--
Manuel Fombuena