Re: [PATCH v3] leds: is31fl319x: modernize registration

On Tue, 04 Aug 2026, Andreas Kemnade wrote:

> On Tue, 04 Aug 2026 13:55:14 +0000
> [email protected] wrote:
> 
> > > leds: is31fl319x: modernize registration  
> > 
> > [Severity: Low]
> > This isn't a bug, but should the description after the subsystem prefix be
> > capitalized? The LED subsystem guidelines recommend formatting commit messages
> > as "leds: <Driver>: <Capitalized description>".
> 
> 
> ~/linux$ grep -R 'leds: <Driver>: <Capitalized description>"' Documentation/
> ~/linux$ ls Documentation/leds/
> index.rst                  leds-lp5521.rst      leds-sc27xx.rst
> leds-blinkm.rst            leds-lp5523.rst      leds-st1202.rst
> leds-cht-wcove.rst         leds-lp5562.rst      ledtrig-oneshot.rst
> leds-class-flash.rst       leds-lp55xx.rst      ledtrig-transient.rst
> leds-class-multicolor.rst  leds-lp5812.rst      ledtrig-usbport.rst
> leds-class.rst             leds-mlxcpld.rst     uleds.rst
> leds-el15203000.rst        leds-mt6370-rgb.rst  well-known-leds.txt
> leds-lm3556.rst            leds-qcom-lpg.rst
> leds-lp3944.rst            leds-s2m-rgb.rst
> 
> nothing look like special guidelines for the system. I do not want to
> see such comments without a reference.
> Also MAINTAINERS does not show any additional policy for the LED subsystem.

`git log --oneline -- <subsystem>` is your friend.

 % git log --oneline -n10 -- drivers/leds
8d6b6c05b8e3 leds: pca9532:  Fix phantom device registration on missing hardware
98c5c7b0d426 leds: gpio:     Make legacy gpiolib interface optional
b6e08e0ad4cf leds: bcm63138: Use %pe to print pinctrl error instead of %ld
07e028d93a57 leds: ltc3220:  Add Support for LTC3220 18 channel LED Driver
cf197514bdfd leds: st1202:   Validate LED reg property against channel count
0767335233a8 leds: st1202:   Disable channel when brightness is set to zero
7cbe470366bd leds: st1202:   Fix brightness having no effect while pattern mode is active
dcc31246aaf0 leds: st1202:   Fix spurious pattern sequence start in setup
d2ca0e2b6d64 leds: st1202:   Set all pattern PWM slots to full after clearing pattern
d32f8bdc2b41 leds: st1202:   Fix pattern duration prescaler and pattern_clear skip marker

-- 
Lee Jones