Re: [RFC PATCH 1/2] dt-bindings: leds: Document TI LM3643 dual LED flash driver

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The schema does not enforce `flash-max-microamp`, `flash-max-timeout-us`, and `led-max-microamp` as required properties for the LED child node.
--

--- Patch [1]: [RFC PATCH 1/2] dt-bindings: leds: Document TI LM3643 dual LED flash driver ---
commit 0c56365dce9a84b7387d67d8621b8beeacea7aec
Author: Rillian Grant <[email protected]>

dt-bindings: leds: Document TI LM3643 dual LED flash driver

This commit documents the devicetree bindings for the Texas Instruments LM3643
dual LED flash driver, which uses a synchronous boost converter to power up to
two current sources up to 1.5A.

> diff --git a/Documentation/devicetree/bindings/leds/ti,lm3643.yaml b/Documentation/devicetree/bindings/leds/ti,lm3643.yaml
> new file mode 100644
> index 0000000000000..18b08a79512f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/ti,lm3643.yaml

[ ... ]

> +patternProperties:
> +  "^led@[0-1]$":
> +    type: object
> +    $ref: common.yaml#
> +    unevaluatedProperties: false

[ ... ]

> +      flash-max-timeout-us:
> +        description: |
> +          The chip supports timeouts from 10ms to 100ms in increments of 10ms
> +          and from 100ms to 400ms in increments of 50ms. The provided value
> +          will be rounded down to a supported value.
> +
> +        minimum: 10000
> +        maximum: 400000
> +
> +    required:
> +      - reg
> +      - led-sources

[Severity: High]
Should flash-max-microamp, flash-max-timeout-us, and led-max-microamp be
included here as required properties for the LED child node?

Without these properties enforced by the schema, a device tree could omit them
and still pass validation. If omitted, will driver fallback to the controller's
absolute maximums (1.5A and 400ms) risk physically damaging connected LEDs that
have lower electrical limits?

> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1