Re: [PATCH v2] parport: mfc3: Convert to a modern zorro driver
Geert Uytterhoeven <[email protected]>
| Newsgroups | org.kernel.vger.linux-m68k,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAMuHMdU-A49FWv4g-RBRkz6DLM4sNOAtWus0zRq_hTZQNaN8FQ@mail.gmail.com> |
On Fri, 27 Feb 2026 at 11:16, Daniel Palmer <[email protected]> wrote: > Currently this driver causes my Amiga 4000 to crash if it > is not a module because it tries to iterate over the zorro > devices before that has been setup. > > Convert the driver over to the modern zorro driver API so > it probes like the other zorro drivers and doesn't crash > my machine. > > Claude was able to do the manual work of moving the original > code but I had to fix up some mistakes, clean up the > allocations to use devm versions and so on. > > Only build, boot, and "checked the driver is registered correctly" > tested as I don't have the card and it seems to be one of the > few things winuae doesn't emulate. Using claude to fix it up > seemed better than just deleting it considering all of the effort > Joerg put in to documenting the hardware etc. > > Assisted-by: Claude:claude-4.6-sonnet > Signed-off-by: Daniel Palmer <[email protected]> > --- > > v2: Clean up how the interrupt works a bit and return IRQ_NONE when the > interrupt wasn't for the card as suggested by Geert. > I guess this should work but without a way to test it this is best > effort. Reviewed-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds