Re: [PATCH] m68k: Fix task info flags handling for 68000
Greg Ungerer <[email protected]>
| Newsgroups | org.kernel.vger.linux-m68k |
|---|---|
| Message-ID | <[email protected]> |
Hi Daniel, On 31/3/26 08:09, Daniel Palmer wrote: > Hi Greg, > > On Wed, 25 Mar 2026 at 20:25, Greg Ungerer <[email protected]> wrote: >> Yeah, agreed. The more I look at the ColdFire version the more I think it >> may not be totally correct. Its flow here doesn't match the comments from >> arch/m68k/include/asm/thread_info.h. The legacy MMU m68k code does appear >> to do as the comments say with respect to the TINFO flag bits. >> >> The ColdFire code was forked from the original arch/m68k/kernel/entry.S >> a very long time back - there was some differences that needed to be dealt >> with. >> >> Anyway what I am looking more closely at is if the higher TINFO flag bits >> are actually not being checked at all - so things like single stepping. > > For now would it be ok to just fix the reschedule flag for 68000 (i.e. > I send a v2 that loads a single byte instead as you suggested). That > would at least make it usable for me and the other few strange people > using it. :) > I have poked around at converting 68000 to the generic entry stuff. I > think that would make most of this custom asm go away... but it'll > take a while before its ready. Yes, lets do that. Send a v2 and I will push into the m68knommu git tree. Regards Greg