Re: [PATCH 1/4] m68k: defconfig: add config for M5329EVB board

Hi Geert,

On 30/4/26 17:04, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Wed, 29 Apr 2026 at 16:27, Greg Ungerer <[email protected]> wrote:
>> From: Greg Ungerer <[email protected]>
>>
>> Add a default configuration file for the Freescale M5329EVB board.
>> Although the SoC type has been supported for a long time there has been
>> no defconfig for the base platform. Create one to give better build
>> and test coverage.
>>
>> Signed-off-by: Greg Ungerer <[email protected]>
> 
> Thanks for your patch!
> 
>> --- /dev/null
>> +++ b/arch/m68k/configs/m5329evb_defconfig
> 
> [...]
> 
>> +CONFIG_FB=y
>> +CONFIG_FRAMEBUFFER_CONSOLE=y
>> +CONFIG_LOGO=y
>> +CONFIG_LOGO_LINUX_MONO=y
>> +CONFIG_LOGO_LINUX_VGA16=y
> 
> [...]
> 
>> +CONFIG_FONTS=y
>> +CONFIG_FONT_8x8=y
>> +CONFIG_FONT_8x16=y
>> +CONFIG_FONT_MINI_4x6=y
> 
> Given you don't enable any fbdev drivers, there is no point in
> enabling CONFIG_FB and derivatives...

The original config this came from had an out of tree fb driver for this device.
So I left these on when importing this. But really probably nothing gained
by leaving them enabled. Will remove.


>> +CONFIG_FRAME_WARN=1024
> 
> Better stick to the default?

Sure, yep.

Regards
Greg