Re: [RFC 4/4] m68k: coldfire: fix non-standard readX()/writeX() functions
Greg Ungerer <[email protected]>
| Newsgroups | org.kernel.vger.linux-m68k,org.kernel.vger.dmaengine,org.kernel.vger.linux-can,org.kernel.vger.linux-kernel,org.kernel.vger.linux-spi |
|---|---|
| Message-ID | <[email protected]> |
On 7/5/26 23:30, Marc Kleine-Budde wrote:
> On 07.05.2026 00:26:48, Greg Ungerer wrote:
>> diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
>> index f5d22c61503f..a682f02d2c43 100644
>> --- a/drivers/net/can/flexcan/flexcan-core.c
>> +++ b/drivers/net/can/flexcan/flexcan-core.c
>> @@ -296,6 +296,7 @@ static_assert(sizeof(struct flexcan_regs) == 0x4 * 18 + 0xfb8);
>> static const struct flexcan_devtype_data fsl_mcf5441x_devtype_data = {
>> .quirks = FLEXCAN_QUIRK_BROKEN_PERR_STATE |
>
> Nitpick:
> Can you move it here, so that the quirks stay sorted?
Yep, sure thing.
> FLEXCAN_QUIRK_DEFAULT_BIG_ENDIAN |
>
>> FLEXCAN_QUIRK_NR_IRQ_3 | FLEXCAN_QUIRK_NR_MB_16 |
>> + FLEXCAN_QUIRK_DEFAULT_BIG_ENDIAN |
>> FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX |
>> FLEXCAN_QUIRK_SUPPORT_RX_FIFO,
>> };
>
> With that change:
>
> Acked-by: Marc Kleine-Budde <[email protected]> # for drivers/net/can/flexcan
Thanks
Greg