Re: [PATCH v2 09/11] m68k: stmark2: use ioport.h macros for resources
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-m68k,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Wed, May 13, 2026 at 11:14:33AM +0200, Angelo Dureghello wrote:
> Align also other resource declaration using DEFINE_RES_.
DEFINE_RES_*()
...
> static struct resource dspi_spi0_resource[] = {
> - [0] = {
> - .start = MCFDSPI_BASE0,
> - .end = MCFDSPI_BASE0 + 0xFF,
> - .flags = IORESOURCE_MEM,
> - },
> - [1] = {
> - .start = 12,
> - .end = 13,
> - .flags = IORESOURCE_DMA,
> - },
> - [2] = {
> - .start = MCF_IRQ_DSPI0,
> - .end = MCF_IRQ_DSPI0,
> - .flags = IORESOURCE_IRQ,
> - },
> + DEFINE_RES_MEM(MCFDSPI_BASE0, 0x100),
> + DEFINE_RES_DMA(12),
> + DEFINE_RES_DMA(13),
> + DEFINE_RES_IRQ(MCF_IRQ_DSPI0),
> };
This conversion drops hard indices, would it be a problem (for example,
some code modifies the fields based on the [hard coded] index...)?
If not, perhaps good to mention in the commit message and move IRQ to be the
second one?
--
With Best Regards,
Andy Shevchenko