Re: [PATCH v2 09/11] m68k: stmark2: use ioport.h macros for resources

Andy Shevchenko <[email protected]> Fri, 15 May 2026 10:38:23 +0300

Newsgroups	org.kernel.vger.linux-m68k,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

On Thu, May 14, 2026 at 09:20:38AM +0200, Angelo Dureghello wrote:
> On 13.05.2026 23:18, Andy Shevchenko wrote:
> > On Wed, May 13, 2026 at 11:14:33AM +0200, Angelo Dureghello wrote:

...

> > This conversion drops hard indices, would it be a problem (for example,
> > some code modifies the fields based on the [hard coded] index...)?
> > 
> > If not, perhaps good to mention in the commit message and move IRQ to be the
> > second one?
> 
> i can't see any directly-related code accessing these resources by index,
> so would not change this if there isn't any risk. 
> Also i see DEFINE_RES_() stuff widely used in other arch, so thios make me
> think accessing by index is something wrong.

OK, thanks for confirming.

-- 
With Best Regards,
Andy Shevchenko