Re: [PATCH] m68k: Avoid -Wunused-but-set-parameter in clear_user_page()
Andreas Schwab <[email protected]>
| Newsgroups | org.kernel.vger.linux-m68k,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mai 24 2026, Thomas Weißschuh wrote:
> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
> index ed782609ca41..67c82c746f7a 100644
> --- a/arch/m68k/include/asm/page_mm.h
> +++ b/arch/m68k/include/asm/page_mm.h
> @@ -55,10 +55,12 @@ static inline void clear_page(void *page)
> #define clear_user_page(addr, vaddr, page) \
> do { clear_page(addr); \
> flush_dcache_page(page); \
> + (void)vaddr; \
> } while (0)
> #define copy_user_page(to, from, vaddr, page) \
> do { copy_page(to, from); \
> flush_dcache_page(page); \
> + (void)vaddr; \
Since vaddr is a macro parameter, I think it would be better to put it
in parens.
--
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."