Re: [PATCH v1 1/8] ata: pata_budda: Use named initializer for zorro_device_id

On Tue, May 26, 2026 at 04:17:27PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Using named initializers is more explicit and thus easier to parse for a
> human.
> 
> It's also more robust to changes in the struct definition. This robustness
> is relevant for a planned change to struct zorro_device_id that replaces
> .driver_data by an anonymous union.
> 
> This change doesn't introduce changes to the compiled zorro_device_id
> array.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>
> ---
>  drivers/ata/pata_buddha.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ata/pata_buddha.c b/drivers/ata/pata_buddha.c
> index c36ee991d5e5..3b1f0ee2f875 100644
> --- a/drivers/ata/pata_buddha.c
> +++ b/drivers/ata/pata_buddha.c
> @@ -253,9 +253,9 @@ static void pata_buddha_remove(struct zorro_dev *z)
>  }
>  
>  static const struct zorro_device_id pata_buddha_zorro_tbl[] = {
> -	{ ZORRO_PROD_INDIVIDUAL_COMPUTERS_BUDDHA, BOARD_BUDDHA},
> -	{ ZORRO_PROD_INDIVIDUAL_COMPUTERS_CATWEASEL, BOARD_CATWEASEL},
> -	{ 0 }
> +	{ .id = ZORRO_PROD_INDIVIDUAL_COMPUTERS_BUDDHA, .driver_data = BOARD_BUDDHA },
> +	{ .id = ZORRO_PROD_INDIVIDUAL_COMPUTERS_CATWEASEL, .driver_data = BOARD_CATWEASEL },
> +	{ }
>  };
>  MODULE_DEVICE_TABLE(zorro, pata_buddha_zorro_tbl);
>  
> @@ -282,7 +282,7 @@ static int __init pata_buddha_late_init(void)
>  	/* Manually bind to all X-Surf boards */
>  	while ((z = zorro_find_device(ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF, z))) {
>  		static struct zorro_device_id xsurf_ent = {
> -			ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF, BOARD_XSURF
> +			.id = ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF, .driver_data = BOARD_XSURF
>  		};
>  
>  		pata_buddha_probe(z, &xsurf_ent);
> -- 
> 2.47.3
> 

Okay for this patch to go via SCSI as suggested by Uwe in the cover-letter:

Acked-by: Niklas Cassel <[email protected]>