Re: [PATCH v1] can: flexcan: Drop unused platform driver data
Uwe Kleine-König (The Capable Hub) <[email protected]>
| Newsgroups | org.kernel.vger.linux-m68k,org.kernel.vger.linux-can,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <ahhAhZ76nLc-eZg8@monoceros> |
Hello Marc,
On Thu, May 28, 2026 at 01:00:15PM +0200, Marc Kleine-Budde wrote:
> On 28.05.2026 11:45:39, Uwe Kleine-König (The Capable Hub) wrote:
> > No function in the flexcan driver ever accesses the .driver_data member
> > of its .id_table array as device_get_match_data() returns NULL for
> > non-of platform devices. So drop that unused assignment.
> >
> > While touching that array, drop the trailing comma after the terminator
> > entry.
>
> Does this mean that commit 5e6c3454b405 ("net: can: Use
> device_get_match_data()") introduced a regression?
Yes, I'd claim that this commit introduces a null pointer exception when
mcf_flexcan0 (defined in arch/m68k/coldfire/device.c) probes.
Best regards
Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoYQm0ACgkQj4D7WH0S /k6P5Af/RigOk1qBi0phQGZoqolZBtvjNCOPhXdtTXZsPHFrRSQHlnNNrCwumgF4 gXsU30alRevFmOywvJQjR20jiQdfyqOz/Lh4rLmTP3/I7kfhEHsQHe35v2Rartas 20cbq4rj8aeF1jFaHth7acd0i0vpLMDS228PzL2qlnNTam51AZWKBqj6GoOzGsmt 00cRVpIB3ZYd8S5sI5g1go5xSeDGFaUgtPMYzzZoBrhzAsqYb+ypG/qSNLvDgn5l 6D4LUQLaDD+Ds6gwzkFPPXfAEmxMQwnT07u6+PQCfPbuGmSNye7H4KEFgdStSD95 6tdn5MsdA99T+oswj7W1DmgD27Gbwg== =UgOY -----END PGP SIGNATURE-----