Re: [PATCH v2 11/11] iio: dac: add mcf54415 DAC

On Thu, May 21, 2026 at 05:14:07AM -0700, Angelo Dureghello wrote:
> On Wed, May 13, 2026 at 11:28:30PM +0300, Andy Shevchenko wrote:
> > On Wed, May 13, 2026 at 11:14:35AM +0200, Angelo Dureghello wrote:

...

> > > +struct mcf54415_dac {
> > > +	struct clk *clk;
> > > +	struct regmap *map;
> >
> > I believe that regmap pointer is used more often, can you check with
> > bloat-o-meter that swapping these two (by the order) gives any benefit in
> > object size?
> >
> 
> checking size in ColdFire arch with last kernel.org gcc had no benefit,
> anyway put regmap before

Thanks for checking.

> > > +};

...

> > > +		return dev_err_probe(dev, PTR_ERR(regs),
> > > +				     "failed to get io regs\n");
> >
> > One line.
> 
> i decided to stay inside 80 in all the file, is it ok ?

It's fine, but for trailing string literals like this the limit was lifted more
than ten years ago. I leave it to the maintainer.

...

> > > +		return dev_err_probe(dev, PTR_ERR(info->clk),
> > > +				     "failed getting clock\n");
> >
> > Also can be a single line, but this one a bit longer than above, gives
> > 88 characters.
> 
> same as above

Ditto.

-- 
With Best Regards,
Andy Shevchenko