Re: [PATCH RESEND v2 1/2] serial: earlycon: add uart_clk_freq parameter

Greg Kroah-Hartman <[email protected]>
Newsgroups org.kernel.vger.linux-m68k,org.kernel.vger.linux-acpi,org.kernel.vger.linux-efi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-serial
Message-ID <2026060957-chaperone-tarot-d548@gregkh>
On Mon, Jun 08, 2026 at 10:40:21PM +0000, Markus Probst wrote:
> Add `uart_clk_freq` parameter to `setup_earlycon`. This allows the
> options string to be reused with `add_preferred_console`, while still
> allowing to set the uart clock frequency. This will be used in the
> following commit ("ACPI: SPCR: Support UART clock frequency field").

Ick, this is bad, now you need to look up what this 0 is as a parameter
every time you see this call.  Please just add a new function that takes
the new paramter, don't abuse the old one for this.

thanks,

greg k-h
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.