Re: [PATCH 22/31] swim: Remove pointless mode0 register write

Laurent Vivier <[email protected]> Sun, 26 Jul 2026 16:51:39 +0200
Newsgroups org.kernel.vger.linux-m68k,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Le 16/07/2026 =C3=A0 12:02, Finn Thain a =C3=A9crit=C2=A0:
> This write has no effect so remove it. (If side =3D=3D 0 then no mode bi=
t gets
> cleared. If side =3D=3D 1 then mode bit 0 gets cleared but that's pointl=
ess
> because that bit is already clear here.)
>=20
> Signed-off-by: Finn Thain <[email protected]>
> ---
>   drivers/block/swim.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Laurent Vivier <[email protected]>

>=20
> diff --git a/drivers/block/swim.c b/drivers/block/swim.c
> index 44fe7a79059c..0bab7ed3daa8 100644
> --- a/drivers/block/swim.c
> +++ b/drivers/block/swim.c
> @@ -467,7 +467,6 @@ static inline int swim_read_sector(struct floppy_sta=
te *fs,
>  =20
>   	swim_track(fs, track);
>   	swim_head(base, side);
> -	swim_write(base, mode0, side);
>  =20
>   	local_irq_save(flags);
>   	for (i =3D 0; i < 36; i++) {