Re: [PATCH 27/31] swim: Remove unused macro definitions

Laurent Vivier <[email protected]> Sun, 26 Jul 2026 17:43:00 +0200
Newsgroups org.kernel.vger.linux-m68k,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Le 16/07/2026 =C3=A0 12:02, Finn Thain a =C3=A9crit=C2=A0:
> Also remove the horizontal rule at the end of the macro definitions as
> it doesn't any add value, IMO.
>=20
> Signed-off-by: Finn Thain <[email protected]>
> ---
>   drivers/block/swim.c | 14 --------------
>   1 file changed, 14 deletions(-)

Reviewed-by: Laurent Vivier <[email protected]>

>=20
> diff --git a/drivers/block/swim.c b/drivers/block/swim.c
> index 444c3f31ba48..9661d8f7a5ed 100644
> --- a/drivers/block/swim.c
> +++ b/drivers/block/swim.c
> @@ -130,25 +130,14 @@ struct iwm {
>  =20
>   /* Bits in handshake register */
>  =20
> -#define MARK_BYTE	0x01
> -#define CRC_ZERO	0x02
> -#define RDDATA		0x04
>   #define SENSE		0x08
> -#define MOTEN		0x10
> -#define ERROR		0x20
>   #define DAT2BYTE	0x40
>   #define DAT1BYTE	0x80
>  =20
>   /* bits in setup register */
>  =20
> -#define S_INV_WDATA	0x01
> -#define S_3_5_SELECT	0x02
> -#define S_GCR		0x04
>   #define S_FCLK_DIV2	0x08
> -#define S_ERROR_CORR	0x10
>   #define S_IBM_DRIVE	0x20
> -#define S_GCR_WRITE	0x40
> -#define S_TIMEOUT	0x80
>  =20
>   /* bits in mode register */
>  =20
> @@ -157,12 +146,9 @@ struct iwm {
>   #define ENBL2		0x04
>   #define ACTION		0x08
>   #define WRITE_MODE	0x10
> -#define HEDSEL		0x20
>   #define ISM_SELECT	0x40
>   #define MOTON		0x80
>  =20
> -/*---------------------------------------------------------------------=
=2D------*/
> -
>   enum drive_location {
>   	NO_DRIVE =3D 0,
>   	INTERNAL_DRIVE =3D BIT(1),