Re: [PATCH v2 5/5] m68k: Add support for Svethlana

Hi Michael,

On Sun, 16 Aug 2026 at 09:38, Michael Schmitz <[email protected]> wrote:
> From: Miro Kropacek <[email protected]>
>
> The SuperVidel FPGA contains an OpenCore ethernet package. Add
> platform device data and other necessary definitions to support
> this device on Atari.
>
> The ethoc module must be enabled separately by the user.
>
> Signed-off-by: Miro Kropacek <[email protected]>
> Reviewed-by: Michael Schmitz <[email protected]>
> Signed-off-by: Michael Schmitz <[email protected]>
> Link: https://lists.debian.org/debian-68k/2026/08/msg00000.html
>
> ---
> Changes in v2:
>
> - fix svethlana platform register error handling (Geert)

Thanks for the update!

> --- a/arch/m68k/atari/config.c
> +++ b/arch/m68k/atari/config.c

> @@ -892,6 +949,23 @@ static int __init atari_platform_init(void)
>         }
>  #endif
>
> +#ifdef CONFIG_ATARI_SVETHLANA
> +       {
> +               int error;
> +               void __iomem *sv_version;
> +
> +               sv_version = ioremap(ATARI_SV_VERSION_PHYS_ADDR, 4);
> +               if (sv_version) {
> +                       if (hwreg_present(sv_version) &&
> +                           (__raw_readl(sv_version) & 0x3ff) >= 10)
> +                               error = platform_device_register(&svethlana_device);
> +                               if (error && !rv)
> +                                       rv = error;

Missing curly braces:

    error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]:

> +                       iounmap(sv_version);
> +               }
> +       }
> +#endif
> +
>  #ifdef CONFIG_ATARI_ETHERNEC
>         {
>                 int error;

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds