Re: [PATCH v2 5/5] m68k: Add support for Svethlana
Michael Schmitz <[email protected]>
| Newsgroups | org.kernel.vger.linux-m68k |
|---|---|
| Message-ID | <[email protected]> |
Hi Geert,
Am 17.08.2026 um 20:52 schrieb Geert Uytterhoeven:
>> +#ifdef CONFIG_ATARI_SVETHLANA
>> + {
>> + int error;
>> + void __iomem *sv_version;
>> +
>> + sv_version = ioremap(ATARI_SV_VERSION_PHYS_ADDR, 4);
>> + if (sv_version) {
>> + if (hwreg_present(sv_version) &&
>> + (__raw_readl(sv_version) & 0x3ff) >= 10)
>> + error = platform_device_register(&svethlana_device);
>> + if (error && !rv)
>> + rv = error;
>
> Missing curly braces:
>
> error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]:
Oops - still does the right thing but just by accident ...
I'll respin, again...
Cheers,
Michael
>
>> + iounmap(sv_version);
>> + }
>> + }
>> +#endif
>> +
>> #ifdef CONFIG_ATARI_ETHERNEC
>> {
>> int error;
>
> Gr{oetje,eeting}s,
>
> Geert
>