Re: [PATCH v1] man/man2/perf_event_open.2: ffix

Alejandro Colomar <[email protected]> Mon, 4 May 2026 14:42:52 +0200
Newsgroups	org.kernel.vger.linux-man
Message-ID	<afiTPYb36pa7a8Pz@devuan>
Hi Robert,

On 2026-05-04T10:57:13+0000, Schneider, Robert wrote:
> Hi Alex,
> 
> Thanks for your hints and links! And for being kind even though you have everything documented 😊
> I broke my machine so I had to reconfigure git etc., I hope that I did not forget anything.

Thanks!  For some reason, the patch didn't apply with git-am(1).
However, it applied with git-apply(1), so I was able to handle it.

> 
> Robert
> 
> ---------
> 
> Fixes .TP list for PERF_SAMPLE_BRANCH_CALL_STACK.
> 
> Fixes: bb7e6ff0 (2015-07-23; "perf_event_open.2: 4.1 PERF_SAMPLE_BRANCH_CALL_STACK")

Heh, nobody has read that documentation in a decade!  :)
The commit that added the documentation was obviously wrong:

	$ diffman-git -U5 bb7e6ff0
	--- bb7e6ff0^:man2/perf_event_open.2
	+++ bb7e6ff0:man2/perf_event_open.2
	@@ -773,11 +773,14 @@ DESCRIPTION
	 
		     PERF_SAMPLE_BRANCH_IN_TX (since Linux 3.11)
			    Branch in transactional memory transaction.
	 
		     PERF_SAMPLE_BRANCH_NO_TX (since Linux 3.11)
	-                   Branch not in transactional memory transaction.
	+                   Branch not in transactional memory transaction.  PERF_SAM‐
	+                   PLE_BRANCH_CALL_STACK (since Linux 4.1) Branch is part of a hardware
	+                   generated call stack.  This requires hardware support, currently
	+                   only found on Intel x86 Haswell or newer.
	 
	      sample_regs_user (since Linux 3.7)
		     This bit mask defines the set of user CPU registers to dump on samples.
		     The layout of the register mask is architecture‐specific and described in
		     the kernel header arch/ARCH/include/uapi/asm/perf_regs.h.

> Signed-off-by: Robert Schneider <[email protected]>

Thanks!  I've applied the patch.


Have a lovely day!
Alex

> ---
>  man/man2/perf_event_open.2 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/man/man2/perf_event_open.2 b/man/man2/perf_event_open.2
> index df0a199e..ae588451 100644
> --- a/man/man2/perf_event_open.2
> +++ b/man/man2/perf_event_open.2
> @@ -1547,6 +1547,7 @@ .SS Arguments
>  .BR PERF_SAMPLE_BRANCH_NO_TX " (since Linux 3.11)"
>  .\" commit 135c5612c460f89657c4698fe2ea753f6f667963
>  Branch not in transactional memory transaction.
> +.TP
>  .BR PERF_SAMPLE_BRANCH_CALL_STACK " (since Linux 4.1)"
>  .\" commit 2c44b1936bb3b135a3fac8b3493394d42e51cf70
>  Branch is part of a hardware-generated call stack.
> --
> 2.43.0
> 
> Robert Schneider (1):
>   man/man2/perf_event_open.2: ffix
> 
>  man/man2/perf_event_open.2 | 1 +
>  1 file changed, 1 insertion(+)
> 
> Range-diff against v1:
> 1:  bc30096a ! 1:  f2c247d1 [PATCH] man/man2/perf_event_open.2: ffix
>     @@ Metadata
>      Author: Robert Schneider <[email protected]>
> 
>       ## Commit message ##
>     -    [PATCH] man/man2/perf_event_open.2: ffix
>     +    [PATCH v1] man/man2/perf_event_open.2: ffix
> 
>          Fixes .TP list for PERF_SAMPLE_BRANCH_CALL_STACK.
> 
>     +    Fixes: bb7e6ff0 (2015-07-23; "perf_event_open.2: 4.1 PERF_SAMPLE_BRANCH_CALL_STACK")
>          Signed-off-by: Robert Schneider <[email protected]>
> 
>       ## man/man2/perf_event_open.2 ##
> --
> 2.43.0
> 
> 
> -----Original Message-----
> From: Alejandro Colomar <[email protected]> 
> Sent: Sunday, 3 May 2026 23:01
> To: Schneider, Robert <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH] man/man2/perf_event_open.2: ffix
> 
> Hi Robert,
> 
> On 2026-04-29T17:35:30+0000, Schneider, Robert wrote:
> > Fixes .TP list for PERF_SAMPLE_BRANCH_CALL_STACK.
> > 
> > Signed-off-by: Robert Schneider <[email protected]>
> 
> Would you mind adding a 'Fixes:' tag?
> 
> See <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/patches/trailer#n16>
> and <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n46>.
> 
> 
> Have a lovely night!
> Alex
> 
> > ---
> >  man/man2/perf_event_open.2 | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/man/man2/perf_event_open.2 b/man/man2/perf_event_open.2 
> > index df0a199e..ae588451 100644
> > --- a/man/man2/perf_event_open.2
> > +++ b/man/man2/perf_event_open.2
> > @@ -1547,6 +1547,7 @@ .SS Arguments
> >  .BR PERF_SAMPLE_BRANCH_NO_TX " (since Linux 3.11)"
> >  .\" commit 135c5612c460f89657c4698fe2ea753f6f667963
> >  Branch not in transactional memory transaction.
> > +.TP
> >  .BR PERF_SAMPLE_BRANCH_CALL_STACK " (since Linux 4.1)"
> >  .\" commit 2c44b1936bb3b135a3fac8b3493394d42e51cf70
> >  Branch is part of a hardware-generated call stack.
> > 
> > Range-diff against v0:
> > -:  -------- > 1:  d597dc98 man/man2/perf_event_open.2: ffix
> > --
> > 2.51.0
> 
> --
> <https://www.alejandro-colomar.es>

-- 
<https://www.alejandro-colomar.es>
signature.asc (application/pgp-signature, 833 B)