Re: [PATCH 2/2] man/man5/core.5: Update compression format for systemd-coredump

On 5/7/26 4:59 PM, Alejandro Colomar wrote:
> Hi Patsy, Carlos,
> 
> On 2026-05-07T15:05:08-0400, Patsy Griffin wrote:
>> As of version 246, systemd-coredump defaults to zstd compression
>> for core dumps, rather than lz4.
>>
>> Signed-off-by: Patsy Griffin <[email protected]>
>> ---
>>   man/man5/core.5 | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/man/man5/core.5 b/man/man5/core.5
>> index 4da5819b6..ee34eded3 100644
>> --- a/man/man5/core.5
>> +++ b/man/man5/core.5
>> @@ -515,9 +515,13 @@ program:
>>   In this case, core dumps will be placed in the location configured for
>>   .BR systemd\-coredump (8),
>>   typically as
>> -.BR lz4 (1)
>> -compressed files in the directory
>> +.BR zstd (1)
>> +compressed files
>> +.\" Since Systemd 246:
>> +.\" commit ef5924aa313d1892bb491c870ba3c429454dfc76
>> +in the directory
>>   .IR /var/lib/systemd/coredump/ .
>> +Compression on or off is configurable via coredump.conf(5).
> 
> Thanks!  I've reformatted it, and moved the comment to the commit
> message, where it's less noisy.
> 
> 	commit XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
> 	Author: Patsy Griffin <[email protected]>
> 	Date:   2026-05-07 15:05:08 -0400
> 
> 	    man/man5/core.5: Update compression format for systemd-coredump
> 	
> 	    As of version 246, systemd-coredump defaults to zstd compression
> 	    for core dumps, rather than lz4.
> 	
> 	    systemd.git ef5924aa (2020-05-04; "coredump: add zstandard support for coredumps")
> 	
> 	    Signed-off-by: Patsy Griffin <[email protected]>
> 	    Message-ID: <[email protected]>
> 	    Reviewed-by: Carlos O'Donell <[email protected]>
> 	    Message-ID: <[email protected]>
> 	    [alx: Minor tweaks]
> 	    Signed-off-by: Alejandro Colomar <[email protected]>
> 
> 	diff --git a/man/man5/core.5 b/man/man5/core.5
> 	index 4da5819b..7b02bd5b 100644
> 	--- a/man/man5/core.5
> 	+++ b/man/man5/core.5
> 	@@ -515,9 +515,11 @@ .SS Core dumps and systemd
> 	 In this case, core dumps will be placed in the location configured for
> 	 .BR systemd\-coredump (8),
> 	 typically as
> 	-.BR lz4 (1)
> 	+.BR zstd (1)
> 	 compressed files in the directory
> 	 .IR /var/lib/systemd/coredump/ .
> 	+Compression on or off is configurable via
> 	+.BR coredump.conf (5).
> 	 One can list the core dumps that have been recorded by
> 	 .BR systemd\-coredump (8)
> 	 using
> 
> Carlos, I've kept your Rb tag, as nothing has changed meaningfully.
> Would you all mind confirming this is okay?
  
Absolutely. LGTM.

  
> Have a lovely night!
> Alex
> 
>>   One can list the core dumps that have been recorded by
>>   .BR systemd\-coredump (8)
>>   using
>> -- 
>> 2.51.1
>>
> 


-- 
Cheers,
Carlos.