Re: [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const)

Hey Alex,

On Sun May 3, 2026 at 10:14 PM BST, Alejandro Colomar wrote:
> Hi Tomasz,
>
> On 2026-05-01T15:57:01+0100, Tomasz Kramkowski wrote:
>> Change the duplicate references to refer to all of the different
>> variants of the TC{GET,SET{S,S2,W}{,W,F}} constants.
>> 
>> This looks to be a bug which was introduced during a restructuring.
>
> Would you mind adding a Fixes:' tag for that bug?  It would help for
> reviewing.
>
> See <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/patches/trailer#n16>
> and <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n46>.

Fixes: e59976296 (2024-06-13; "ioctl_tty.2, TC[SG]ET*.2const: Split TC[SG]ET* from ioctl_tty(2)")

I hope this is sufficient, but if not, let me know and I will re-send
the patch with the tag.

Thanks,

Tomasz

> Have a lovely night!
> Alex
>
>> 
>> Signed-off-by: Tomasz Kramkowski <[email protected]>
>> ---
>>  man/man2/ioctl_tty.2 | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>> 
>> diff --git a/man/man2/ioctl_tty.2 b/man/man2/ioctl_tty.2
>> index 1d6e279c0..cb2776867 100644
>> --- a/man/man2/ioctl_tty.2
>> +++ b/man/man2/ioctl_tty.2
>> @@ -42,21 +42,21 @@ whenever possible.
>>  .TQ
>>  .BR TCSETSF (2const)
>>  .TP
>> -.BR TCGETS (2const)
>> +.BR TCGETS2 (2const)
>>  .TQ
>> -.BR TCSETS (2const)
>> +.BR TCSETS2 (2const)
>>  .TQ
>> -.BR TCSETSW (2const)
>> +.BR TCSETSW2 (2const)
>>  .TQ
>> -.BR TCSETSF (2const)
>> +.BR TCSETSF2 (2const)
>>  .TP
>> -.BR TCGETS (2const)
>> +.BR TCGETA (2const)
>>  .TQ
>> -.BR TCSETS (2const)
>> +.BR TCSETA (2const)
>>  .TQ
>> -.BR TCSETSW (2const)
>> +.BR TCSETAW (2const)
>>  .TQ
>> -.BR TCSETSF (2const)
>> +.BR TCSETAF (2const)
>>  .SS Locking the termios structure
>>  .TP
>>  .BR TIOCGLCKTRMIOS (2const)
>> -- 
>> 2.51.0
>> 

-- 
Tomasz (Tom) Kramkowski