Re: non-standard const-preserving string APIs
Alejandro Colomar <[email protected]> Tue, 2 Jun 2026 00:10:48 +0200
| Newsgroups | org.kernel.vger.linux-man |
|---|---|
| Message-ID | <ah4CutusqxigD5kW@devuan> |
Hi Florian, On 2026-06-01T13:41:16+0200, Florian Weimer wrote: > > I will try to take a look, but I recall from previous weekly calls > > that Florian has raised objection that this does not solve the > > overflow issue (not without further extra changes). > > <https://inbox.sourceware.org/libc-alpha/[email protected]/> > > > I am not sure if he still keep his objection, nor if it is would a > > blocker for this new api. > > I still think we should fix it. Maybe rename the “done” variable in the > vfprintf internals to “ssize_t”, and then gradually fix the compilation > failures, investigating whether the change is correct in context. We > need to add some early bailout in case INT_MAX is crossed for the > non-aprintf case. Would you mind at least confirming whether the current patches are OK modulo the EOVERFLOW issue? It's the first time I touch many of these files (e.g., abilist files), and I'd appreciate if you reviewed it so that I can forget about that part. Have a lovely night! Alex > > Thanks, > Florian > -- <https://www.alejandro-colomar.es>
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmoeA2cACgkQ64mZXMKQ wqmV1A/9HPXHAj7mvCCvPIHUs0asnqLzQri3Deo7YpEHBQR+Sut2wF1mhYndscfc n+InDmrJdXHzSVmKZV9yRrWOUAuEAeDPkULINhAqKQ+0wv1nsgq++ddkxA9ZWy6w gUQMlMp5K6Za5TimGzqJm+0WbHiZmdhsDmarSrCRG9HsZJFxJPxAnvg9OyRhjKF6 zp5wH8XnHHmGbpydm+DFpdbFh823A+uiAmyciDDaUHyuYnSQhedyrRRP6A696ZN/ Q7f1rl+WdDXor3iPHJ725BywFvH37qFo4QfL/MLn0xpqnfPxaMsmT8CiEkzr/05+ rT9ZmnrY03uokYssayV3jcnydBmlkpnD5HbPM3ULPqPlM00U2g6yKCTmKVKs3NAt NUFrZIo3L0nLoGyBjpRMyQdVku792ZFHk+wczVPDSJ3YP8OM9BcJQX8y/sZ4Q3Y8 b+FnX+1k0KUCAR4aVlMtSbHwysFDbpG64RHYJVwVI0NwSp6H4Kfp4BhXbochs2q7 rM5dhGxT29IpVYkiJ5l65yOOb73NJUMAQpx9MaenJLljf5SSUE3ErpdnxJYLH6M6 yLtFGnfX8jUJPebMlNM3lWyXnbn6UzpJAHKeki4yDu/6xq1Ppg3R7c0U1f8VcK0N PQ3MnJcNqQYXZcVRac4NeGKwrm1ISAqiAPCBll3wCKt/sx5zvBE= =1GB5 -----END PGP SIGNATURE-----