Re: [PATCH v3 2/4] man/man5/tunables.conf: Document system-wide tunables config

Alejandro Colomar <[email protected]> writes:
> '-' should be escaped: '\-'

Fixed.

> Also, these examples don't need bold.  We use bold to differentiate from
> program output, when we have examples that show both a command and its
> output.  In this case, being just a simple command, it's fine in roman.
>
> 	ld.so \-\-list\-tunables

Fixed.

> For consistency with patch 1/4, this should use the same wording:
>
> 	The syntax allows lines to start with the keyword
> 	.B include
> 	followed by a
> 	.BR glob (7)
> 	pattern.
>
> It's also much simpler.

Fixed.  I thought I got all of those in sync...

>> +The file is parsed by
>> +.BR \%ldconfig (8)
>> +and the results stored in
>> +.IR /etc/ld.so.cache .
>
> In patch 1/4 (ld.so.conf(5)), this paragraph is specified above the
> specification of 'include'.  We should be consistent.  Do you prefer it
> above in both, or below in both?

I moved it here.

> (I haven't pushed patch 1 yet, so if you want to modify it, I can amend
>  it.)

Well, you did push it ;-)

I added a signed-off-by to the new 2/4 but I've never had to do that due
to Red Hat's blanket copyright assignments everywhere.  Assuming those
are in place for man-pages, I was under the impression that a
signed-off-by would be contra-indicated.