Re: [PATCH] man/man2/statmount.2: Fix incorrect function signature
Alejandro Colomar <[email protected]>
| Newsgroups | org.kernel.vger.linux-man,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <aoLOb0tixHee3AkZ@debian> |
Hi Bhavik, Josef, > Date: 2026-08-15 13:15:26+0530 > From: Bhavik Sachdev <[email protected]> > > flags argument is an unsigned int not an unsigned long [1]. > > [1]: > <https://github.com/torvalds/linux/blob/master/fs/namespace.c#L5961> Thanks! > Fixes: c011cc992510 (2024-07-09; "statmount.2: Add page") Please CC the people involved in that commit. (I've done it now.) > Signed-off-by: Bhavik Sachdev <[email protected]> > --- > man/man2/statmount.2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/man2/statmount.2 b/man/man2/statmount.2 > index b6d9dc2a1..a365002dd 100644 > --- a/man/man2/statmount.2 > +++ b/man/man2/statmount.2 > @@ -16,7 +16,7 @@ Standard C library > .P > .BI "int syscall(SYS_statmount, struct mnt_id_req *" req , > .BI " struct statmount *" smbuf ", size_t " bufsize , > -.BI " unsigned long " flags ); > +.BI " unsigned int " flags ); LGTM. $ grepc -tfld statmount . | head -n4 ./fs/namespace.c:SYSCALL_DEFINE4(statmount, const struct mnt_id_req __user *, req, struct statmount __user *, buf, size_t, bufsize, unsigned int, flags) { Josef, was it just a typo, or is there anything that needs checking? Have a lovely day! Alex > .P > .B #include <linux/mount.h> > .fi > -- > 2.53.0 > > -- <https://www.alejandro-colomar.es>
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmqCz1oACgkQ64mZXMKQ wqkHEw//e6snaLK/8FrcBF5CzGW2CldFqAHQsDCGSHKUd9OCV34jy5h2PL6YMS34 VDlgKLvAMRHS0hJnJbgtudGAEEgNRHYwWHDqLZXyeL7q+vAmhp9lUUTBFe1FlGLt KUIXC/U2o9tUtCJDGargmYCII9GyUs63+fhgJbCZut01r0x2K5ec1KzyDLnK30am onHfBZ6u6uj62tq1PPtg8fdrqxqbRZkUw8uU9Fl4lpb4cZz4ZcHTKNrYM0caebnC hIttdlANhUetugsA84htE1/diQiPMcaQ8+1Y6c8qMQxvWt7hNrHpBexvoWg1vAL6 uIL5vrlPx1vPOaQeblbXnt6OtpO99mooGj+AwvMF95yLPHgGHBsFhYA9HaFrvvsy 0hXpNnFi0x5au0k72UH+BMvoWp9BRMoKRHpra8o4hw/fwRKs5u3azNPPaHaAa3+q lpki2li7wALzIbI6edrWAIdi/VLshne9+26fqsuSUYdKl2QSy2dH6IpaOKsxGY1l hdNYQ9aPpYzLz90ly/8+pD0AjIcp9Kndq9unWotv6B7UM82yzlnlfwS204XNC5eL At6dD4+YwdLkQcPlf4wyKNrmbEvoVJPKHtPBthNaBUbm7R+HO+Fcjn395aSnRNEL mDMlQ229Vcij2DwKttDK2+R2i3fKK7Ef5SeRGr8rQ+bVlAa7AU4= =S4v5 -----END PGP SIGNATURE-----