[PATCH v2 0/2] Enable DW9714V camera focus coil on SHIFT 6MQ
David Heidelberg via B4 Relay <[email protected]>
| Newsgroups | org.kernel.vger.linux-media,org.kernel.feeds.b4-sent,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.phone-devel |
|---|---|
| Message-ID | <[email protected]> |
Implements wiring for: - SGM2036 linear regulator used by the cci i2c camera module [1] - Dongwoon 9714V focus coil used by IMX519 camera sensor [2] [1] https://www.sg-micro.com/rect/assets/efa85993-263c-41aa-9274-b488f59f85d5/SGM2036.pdf [2] https://datasheet4u.com/pdf/1247146/DW9714V.pdf Open question for future work: modeling the I2C bus supply. Like many similar chips, the DW9714 has a single VDD supply, but its I2C lines go through a level shifter to a 1.8V rail, and there is currently no place in DT to describe that rail so it gets enabled during I2C access to the device. As a stopgap, this series models it as an always-on fixed regulator (see the TODO in the cam_bus_2p8 node). Direction agreed with Rob Herring and Mark Brown on IRC: - Modeling the level shifter itself is overkill as long as it is just a supply; modeling the connector would come first if needed. - Since each side of the shifter has its own supply, the proper solution is a generic 'bus-supply' property valid in both the I2C controller and device nodes. - Defining it per-device-schema would ideally use an I2C equivalent of spi-peripheral-props.yaml, which does not exist yet. The pragmatic interim is to define bus-supply in i2c-controller.yaml for both places and add 'bus-supply: true' to schemas that need it now (dw9714), deferring the peripheral-props question until more shared device properties accumulate. Once bus-supply exists, the regulator-always-on workaround in this DTS can be dropped. Signed-off-by: David Heidelberg <[email protected]> --- Changes in v2: - Address Sashiko findings. - Link to v1: https://patch.msgid.link/[email protected] --- David Heidelberg (2): dt-bindings: media: i2c: dongwoon,dw9714: Document DW9714A and V variant arm64: dts: qcom: sdm845-shift-axolotl: Add actuator for main rear camera .../bindings/media/i2c/dongwoon,dw9714.yaml | 10 +++- arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 61 ++++++++++++++++++++++ 2 files changed, 70 insertions(+), 1 deletion(-) --- base-commit: 78bc8af4affb9a732504eb22eeac7d1e50883853 change-id: 20260416-dw9714v-4566465ebe7d Best regards, -- David Heidelberg <[email protected]>