Re: [PATCH v3 1/4] media: qcom: camss: Add PM clock support and integrate with runtime PM

Loic Poulain <[email protected]> Thu, 30 Jul 2026 11:49:17 +0200

Newsgroups	org.kernel.vger.linux-media,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel
Message-ID	<CAFEp6-0fk+-jTNEEV3+CgmnxZ-CiLH_FWg=gm_GMvURYeo390Q@mail.gmail.com>

On Thu, Jul 30, 2026 at 11:35 AM Bryan O'Donoghue
<[email protected]> wrote:
>
> On 30/07/2026 10:24, Loic Poulain wrote:
> > +     ret = devm_pm_clk_create(dev);
> > +     if (ret)
> > +             return ret;
>
> !PM_CLK this is an -EINVAL I think.

It is, but we should probably still allow to compile-test the driver
without PM_CLK?
Maybe we should just add a 'depends on PM' since PM_CLK is enabled by
default along PM, and we functionally really want to run our
suspend/resume callback for proper driver behavior.

Regards,
Loic