Re: [PATCH 2/2] media: i2c: Add driver for Sony IMX662 sensor

Hi Jai

On Tue, 21 Jul 2026 at 06:06, Jai Luthra <[email protected]> wrote:
>
> Hi Dave,

<snip>

> > > and implement
> > > it using the common raw sensor model directly?
> > >
> > > I did it for IMX678 [1] on Sakari's suggestion [2]. The two sensors are
> > > quite similar, so I'm happy to help in whatever way I can on getting this
> > > working with the new model too :-)

I'd also noticed that all the Starvis 2 sensors are very similar, to
the extent that it seemed worth a very quick test to see how much
needed to change for the imx678 driver to work with imx662.

The answer turned out to be really not much:
- PIXEL_RATE
- PIX_PER_CLK
- ID
- native and active areas
- min_hmax
- common_regs (culled nearly all of them, although I do have the
spreadsheet from Sony which needs to be added to my next version)
- VMAX_DEFAULT setup if you want the full frame rate.

Those would all parameterise quite easily.

I also have an IMX675 module from Soho Enterprises which is a 5MPix
Starvis 2 sensor. I don't have a datasheet for it at present.
That streams OK at the requested rates by just updating the active
area to 2608x1960 and ignoring the ID. However I can only receive test
patterns as all the active images I get are pure black :( I'm hoping
it's a faulty module, but will keep poking.

There is also IMX585 as an 8MPix Starvis2 sensor. I'd hoped Naush had
one to test, but it seems not. In the meantime I've compared against
the driver Will Whang sent to linux-media a while back [1] and that
also looks largely the same.

And the imx908 Starvis 3 driver that has just been posted [2] is also
looking incredibly similar.

So the big question is whether it is better to have separate drivers
for all these sensors, or one combined Starvis2/3 driver? Do we shoot
ourselves in the foot when we come to add functionality and find that
it only applies to some models?
The awkward part would be testing all variants when patches are
submitted, as I suspect there won't be one person that has access to
all of them.

Thoughts appreciated.

  Dave

[1] https://lore.kernel.org/linux-media/[email protected]/
[2] https://lore.kernel.org/linux-media/[email protected]/T/#t