Re: [PATCH v10 1/2] dt-bindings: media: i2c: Add mira220 image sensor

On Fri, Jul 31, 2026 at 04:31:58PM +0200, Jacopo Mondi wrote:
> Hi Sakari
> 
> On Tue, Jul 28, 2026 at 05:43:54PM +0300, Sakari Ailus wrote:
> > Hi Jacopo,
> >
> > On Mon, Jul 27, 2026 at 10:56:30AM +0200, Jacopo Mondi wrote:
> > > From: Philippe Baetens <[email protected]>
> > >
> > > Add bindings for the AMSOSRAM Mira220 image sensor.
> > >
> > > Acked-by: Conor Dooley <[email protected]>
> > > Signed-off-by: Philippe Baetens <[email protected]>
> > > Signed-off-by: Jacopo Mondi <[email protected]>
> > >
> > > ---
> > > v8->v9:
> > > - Make link-frequencies required
> > >
> > > v7->v8:
> > > - Add Conor's tag
> > >
> > > v5->v6:
> > > - sashiko: use 'unevaluatedProperties: false' at the top level to allow
> > >   properties from video-interface-devices.yaml
> > >
> > > v4->v5:
> > > - reflow description to 80 cols and drop |-
> > > - remove 'reg' description
> > > - remove 'anyOf' from data-lanes
> > > - remove 'link-frequencies' from required properties
> > > - remove 'clock-continuous: true' as we already allow all properties
> > >   from 'video-interfaces.yaml'
> > > - remove tabs from the example
> > > ---
> > >  .../devicetree/bindings/media/i2c/ams,mira220.yaml | 102 +++++++++++++++++++++
> > >  MAINTAINERS                                        |   7 ++
> > >  2 files changed, 109 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> > > new file mode 100644
> > > index 000000000000..fa6fec0072ef
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> > > @@ -0,0 +1,102 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/i2c/ams,mira220.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: AMS 2.2 MP NIR enhanced global shutter image sensor
> > > +
> > > +maintainers:
> > > +  - Philippe Baetens <[email protected]>
> > > +
> > > +description:
> > > +  2.2 MP NIR enhanced global shutter image sensor designed for 2D and 3D
> > > +  consumer and industrial machine vision applications. Due to its small size,
> > > +  configurability and high sensitivity both in visual as well as NIR, the
> > > +  Mira220 is well suited for 2D and 3D applications, which include Active Stereo
> > > +  Vision, Structured Light Vision for Robotics and AR/VR.
> > > +
> > > +allOf:
> > > +  - $ref: /schemas/media/video-interface-devices.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: ams,mira220
> >
> > I haven't read the discussion on all versions of the set, but this way
> > you'll have to power on the device to fully recognise it, further meaning
> > the possible hardwired privacy LED will be lit at that time. Maybe it's not
> > an issue. You'd likely have it with a CCS sensor, too...
> 
> Yes, we run-time identify the sensor.
> 
> I don't think it's an issue, and it ends up being one, we can add a
> compatible for the mono or ir variants and use this one a the generic
> fallback ?

Sounds good to me.

-- 
Sakari Ailus