Re: [PATCH 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor bindings

On Mon, Aug 03, 2026 at 08:16:10AM +0200, Krzysztof Kozlowski wrote:
> On 03/08/2026 01:03, Laurent Pinchart wrote:
> > On Thu, Jul 30, 2026 at 11:06:09AM +0200, Krzysztof Kozlowski wrote:
> >> On Thu, Jul 30, 2026 at 11:15:24AM +0900, Lachlan Michael wrote:
> >>> The Sony IMX908 is an 8.39 megapixel (3856x2176) CMOS image sensor
> >>> with a MIPI CSI-2 output interface.
> >>>
> >>> Add device tree bindings for the sensor.
> >>>
> >>> Signed-off-by: Lachlan Michael <[email protected]>
> >>
> >> You need to test code before you send it, not with our infra.
> > 
> > I have provided guidance to Lachlan on how to test DT bindings (and have
> > submitted a fix to dt-schema as part of that work) before he submitted
> > this patch series. Unfortunately, we missed an issue in the
> > configuration of his development environment which resulted in the DT
> > bindings check not being run. Mistakes happen, it will work better next
> > time :-)
> > 
> >> To spare you one sending cycle:
> >>
> >> A nit, subject: drop second/last, redundant "bindings". The
> >> "dt-bindings" prefix is already stating that these are bindings.
> >> See also:
> >> https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23
> >>
> >>> ---
> >>>  .../bindings/media/i2c/sony,imx908.yaml       | 107 ++++++++++++++++++
> >>>  MAINTAINERS                                   |   7 ++
> >>>  2 files changed, 114 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> >>
> >> ...
> >>
> >>> +++ b/MAINTAINERS
> >>> @@ -25264,6 +25264,13 @@ T:	git git://linuxtv.org/media.git
> >>>  F:	Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> >>>  F:	drivers/media/i2c/imx415.c
> >>>  
> >>> +SONY IMX908 SENSOR DRIVER
> >>> +M:	Lachlan Michael <[email protected]>
> >>> +L:	[email protected]
> >>
> >> Drop
> > 
> > Why so ?
> 
> It's just redundant and bloat. The address will ALWAYS appear through
> the subsystem maintainers entry, thus duplicating exactly the same list
> is not necessary. Many drivers make the same mistake (I fixed Samsung
> now) resulting in quite big amount of redundant data.

Good point, thanks for the explanation. I'm fine with that. I'd like
Sakari's opinion though. If he disagrees, I'll let the two of you debate
this, and Lachlan can then drop or keep the L: line based on the
conclusion :-)

-- 
Regards,

Laurent Pinchart