Re: [PATCH v2] staging: media: av7110: remove unnecessary parentheses from return

On Tue, Aug 04, 2026 at 07:49:51AM +0000, Ashmit Kumar wrote:
> The Linux kernel coding style specifies that return is not a function
> and therefore parentheses are not required.
> 
> Signed-off-by: Ashmit Kumar <[email protected]>
> ---
>  drivers/staging/media/av7110/sp8870.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c
> index 29fb4934c03..83c6ee305d6 100644
> --- a/drivers/staging/media/av7110/sp8870.c
> +++ b/drivers/staging/media/av7110/sp8870.c
> @@ -92,7 +92,7 @@ static int sp8870_readreg(struct sp8870_state *state, u16 reg)
>  		return -1;
>  	}
>  
> -	return (b1[0] << 8 | b1[1]);
> +	return b1[0] << 8 | b1[1];
>  }
>  
>  static int sp8870_firmware_upload(struct sp8870_state *state, const struct firmware *fw)
> @@ -167,7 +167,7 @@ static void sp8870_microcontroller_start(struct sp8870_state *state)
>  
>  static int sp8870_read_data_valid_signal(struct sp8870_state *state)
>  {
> -	return (sp8870_readreg(state, 0x0D02) > 0);
> +	return sp8870_readreg(state, 0x0D02) > 0;
>  }
>  
>  static int configure_reg0xc05(struct dtv_frontend_properties *p, u16 *reg0xc05)
> -- 
> 2.51.0.windows.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot