RE: [PATCH v4 1/2] media: i2c: ov8856 : remove ACPI node bypass mechanism

Hi Sakari,

Thanks for the feedback.

-----Original Message-----
From: Sakari Ailus <[email protected]> 
Sent: Thursday, August 6, 2026 6:21 PM
To: Yeh, Serin <[email protected]>
Cc: [email protected]; Su, Jimmy <[email protected]>; Sapre, Sarang <[email protected]>; [email protected]; [email protected]; [email protected]; Bryan O'Donoghue <[email protected]>
Subject: Re: [PATCH v4 1/2] media: i2c: ov8856 : remove ACPI node bypass mechanism

Hi Serin,

>>On Thu, Aug 06, 2026 at 02:18:04PM +0800, Serin Yeh wrote:
>> On Intel platforms the sensor is enumerated via ACPI, and an INT3472 
>> "discrete" companion device (the power-logic-control driver under
>> drivers/platform/x86/intel/int3472) registers the sensor's 
>> reset/powerdown GPIOs and the regulator supply. These resources are 
>> therefore discoverable and usable through the standard gpiod/regulator 
>> lookups at probe time.
>> 
>> However, the driver guarded both the GPIO/regulator acquisition in
>> ov8856_get_hwcfg() and the whole power-on/off sequence with
>> is_acpi_node() and skipped them on ACPI. As a result the sensor was 
>> never powered or reset by the driver, and probe failed when reading 
>> the chip ID in ov8856_identify_module().
>> 
>> Remove the is_acpi_node() checks so the GPIO/regulator resources are 
>> acquired and the full power sequence runs regardless of the firmware 
>> interface. The driver now behaves consistently across DT and ACPI 
>> platforms and initialises the hardware correctly.
>> 
>> Tested on Intel platforms with kernel 6.17 and 7.0.

> Only testing on current kernel matters so this is rather redundant. If there are no other changes needed, I'll drop this and Fixes:/Cc: tags while applying.

No other changes needed on my side. Please go ahead and drop the Fixes:/Cc: stable tags as you prefer.

Thanks.

>> 
>> Fixes: d2fa1134a48b ("media: i2c: ov8856: Use V4L2 legacy sensor clock 
>> helper")
>> Cc: [email protected]
>> Signed-off-by: Serin Yeh <[email protected]>
>> Reviewed-by: Bryan O'Donoghue <[email protected]>