Re: [PATCH v7 10/14] media: v4l2-subdev: Don't assign set_fmt where it's equivalent to get_fmt

On 07/08/2026 14:24, Sakari Ailus wrote:
> Do not assign the set_fmt() pad op where it is the same as get_fmt(). The
> get_fmt() pad op is called by the framework now in absence of set_fmt()
> op.
> 
> Signed-off-by: Sakari Ailus <[email protected]>

Reviewed-by: Hans Verkuil <[email protected]>

Regards,

	Hans

> ---
>  drivers/media/i2c/ak881x.c                | 1 -
>  drivers/media/i2c/gc0310.c                | 1 -
>  drivers/media/i2c/rdacm20.c               | 1 -
>  drivers/media/i2c/rdacm21.c               | 1 -
>  drivers/media/i2c/tvp5150.c               | 1 -
>  drivers/staging/media/max96712/max96712.c | 1 -
>  6 files changed, 6 deletions(-)
> 
> diff --git a/drivers/media/i2c/ak881x.c b/drivers/media/i2c/ak881x.c
> index cea46f01997d..4cedfc2d4136 100644
> --- a/drivers/media/i2c/ak881x.c
> +++ b/drivers/media/i2c/ak881x.c
> @@ -216,7 +216,6 @@ static const struct v4l2_subdev_video_ops ak881x_subdev_video_ops = {
>  static const struct v4l2_subdev_pad_ops ak881x_subdev_pad_ops = {
>  	.enum_mbus_code = ak881x_enum_mbus_code,
>  	.get_selection	= ak881x_get_selection,
> -	.set_fmt	= ak881x_fill_fmt,
>  	.get_fmt	= ak881x_fill_fmt,
>  };
>  
> diff --git a/drivers/media/i2c/gc0310.c b/drivers/media/i2c/gc0310.c
> index 754e82ad50ae..f2c381602d18 100644
> --- a/drivers/media/i2c/gc0310.c
> +++ b/drivers/media/i2c/gc0310.c
> @@ -537,7 +537,6 @@ static const struct v4l2_subdev_pad_ops gc0310_pad_ops = {
>  	.enum_mbus_code = gc0310_enum_mbus_code,
>  	.enum_frame_size = gc0310_enum_frame_size,
>  	.get_fmt = v4l2_subdev_get_fmt,
> -	.set_fmt = v4l2_subdev_get_fmt, /* Only 1 fixed mode supported */
>  	.get_selection = gc0310_get_selection,
>  	.set_selection = gc0310_get_selection,
>  	.enable_streams = gc0310_enable_streams,
> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> index 52e8e2620b4d..0179508626b5 100644
> --- a/drivers/media/i2c/rdacm20.c
> +++ b/drivers/media/i2c/rdacm20.c
> @@ -442,7 +442,6 @@ static const struct v4l2_subdev_video_ops rdacm20_video_ops = {
>  static const struct v4l2_subdev_pad_ops rdacm20_subdev_pad_ops = {
>  	.enum_mbus_code = rdacm20_enum_mbus_code,
>  	.get_fmt	= rdacm20_get_fmt,
> -	.set_fmt	= rdacm20_get_fmt,
>  };
>  
>  static const struct v4l2_subdev_ops rdacm20_subdev_ops = {
> diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
> index ece8a410e7ce..68d2b9d83c3c 100644
> --- a/drivers/media/i2c/rdacm21.c
> +++ b/drivers/media/i2c/rdacm21.c
> @@ -322,7 +322,6 @@ static const struct v4l2_subdev_video_ops rdacm21_video_ops = {
>  static const struct v4l2_subdev_pad_ops rdacm21_subdev_pad_ops = {
>  	.enum_mbus_code = rdacm21_enum_mbus_code,
>  	.get_fmt	= rdacm21_get_fmt,
> -	.set_fmt	= rdacm21_get_fmt,
>  };
>  
>  static const struct v4l2_subdev_ops rdacm21_subdev_ops = {
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 9c204f38935d..5b92424a0148 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1724,7 +1724,6 @@ static const struct v4l2_subdev_vbi_ops tvp5150_vbi_ops = {
>  static const struct v4l2_subdev_pad_ops tvp5150_pad_ops = {
>  	.enum_mbus_code = tvp5150_enum_mbus_code,
>  	.enum_frame_size = tvp5150_enum_frame_size,
> -	.set_fmt = tvp5150_fill_fmt,
>  	.get_fmt = tvp5150_fill_fmt,
>  	.get_selection = tvp5150_get_selection,
>  	.set_selection = tvp5150_set_selection,
> diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> index 0751b2e04895..94ae304ac85f 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -264,7 +264,6 @@ static const struct v4l2_subdev_internal_ops max96712_internal_ops = {
>  
>  static const struct v4l2_subdev_pad_ops max96712_pad_ops = {
>  	.get_fmt = v4l2_subdev_get_fmt,
> -	.set_fmt = v4l2_subdev_get_fmt,
>  };
>  
>  static const struct v4l2_subdev_ops max96712_subdev_ops = {