[PATCH v2] media: ipu-bridge: check all DMI entries when overriding sensor rotation

A machine can have more than one sensor whose rotation needs to be
overridden, which takes one upside_down_sensor_dmi_ids[] entry per
sensor, all sharing the same DMI match but with different ACPI HIDs in
driver_data.

ipu_bridge_parse_rotation() uses dmi_first_match(), which always stops
at the first entry matching the running machine, so any further entry
for the same machine is unreachable and only one sensor per machine can
ever be corrected.

Walk the whole table and match every entry for the running machine
against the sensor's ACPI HID instead.

Fixes: b75710155a82 ("media: ipu-bridge: Add DMI quirk for Dell XPS laptops with upside down sensors")
Signed-off-by: José María Martín <[email protected]>
---
No machine in the mainline table lists two sensors yet, so this has no
effect on mainline today. It matters downstream: the Microsoft Surface
Pro 9 has both its front (OVTI5693) and rear (OVTID858) cameras mounted
upside down while its SSDB reports degree=0 for both, and the
linux-surface kernel carries such a pair of entries and hits this
limitation.

Tested on a Surface Pro 9 (6.19-based linux-surface kernel with this
change backported): both cameras report Rotation = 180 and render
upright in libcamera clients.

Changes since v1:
- moved the Surface Pro 9 background and the testing notes below the ---
- added a Fixes: tag
- shortened the code comment to a single line

 drivers/media/pci/intel/ipu-bridge.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
index 88581a4..ad3ddfb 100644
--- a/drivers/media/pci/intel/ipu-bridge.c
+++ b/drivers/media/pci/intel/ipu-bridge.c
@@ -298,9 +298,11 @@ static u32 ipu_bridge_parse_rotation(struct acpi_device *adev,
 {
 	const struct dmi_system_id *dmi_id;
 
-	dmi_id = dmi_first_match(upside_down_sensor_dmi_ids);
-	if (dmi_id && acpi_dev_hid_match(adev, dmi_id->driver_data))
-		return 180;
+	/* A machine may have one entry per sensor, so check all matches. */
+	for (dmi_id = dmi_first_match(upside_down_sensor_dmi_ids); dmi_id;
+	     dmi_id = dmi_first_match(dmi_id + 1))
+		if (acpi_dev_hid_match(adev, dmi_id->driver_data))
+			return 180;
 
 	switch (ssdb->degree) {
 	case IPU_SENSOR_ROTATION_NORMAL:
-- 
2.55.0