[PATCH v2 2/5] media: rkvdec: Remove unused need_reset
Detlev Casanova <[email protected]>
| Newsgroups | org.kernel.vger.linux-media,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
A left-over from the iommu restore mecanism was forgotten. As need_reset is never set to true, the if has no use. The actual restore function is called above it vase the IRQ isn't in a success status. Signed-off-by: Detlev Casanova <[email protected]> --- drivers/media/platform/rockchip/rkvdec/rkvdec.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c index 31ddfcc58894..db2731af06cf 100644 --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c @@ -1462,7 +1462,6 @@ static irqreturn_t vdpu381_irq_handler(struct rkvdec_ctx *ctx) { struct rkvdec_dev *rkvdec = ctx->dev; enum vb2_buffer_state state; - bool need_reset = 0; u32 status; status = readl(rkvdec->regs + VDPU381_REG_STA_INT); @@ -1478,9 +1477,6 @@ static irqreturn_t vdpu381_irq_handler(struct rkvdec_ctx *ctx) rkvdec_iommu_restore(rkvdec); } - if (need_reset) - rkvdec_iommu_restore(rkvdec); - if (cancel_delayed_work(&rkvdec->watchdog_work)) rkvdec_job_finish(ctx, state); @@ -1491,7 +1487,6 @@ static irqreturn_t vdpu383_irq_handler(struct rkvdec_ctx *ctx) { struct rkvdec_dev *rkvdec = ctx->dev; enum vb2_buffer_state state; - bool need_reset = 0; u32 status; status = readl(rkvdec->link + VDPU383_LINK_STA_INT); @@ -1507,9 +1502,6 @@ static irqreturn_t vdpu383_irq_handler(struct rkvdec_ctx *ctx) rkvdec_iommu_restore(rkvdec); } - if (need_reset) - rkvdec_iommu_restore(rkvdec); - if (cancel_delayed_work(&rkvdec->watchdog_work)) rkvdec_job_finish(ctx, state); -- 2.55.0