Re: [PATCH v2] media: ipu-bridge: check all DMI entries when overriding sensor rotation
Sakari Ailus <[email protected]>
| Newsgroups | org.kernel.vger.linux-media |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
Hi José,
On Mon, Aug 10, 2026 at 04:30:26PM +0200, José MarÃa MartÃn wrote:
> A machine can have more than one sensor whose rotation needs to be
> overridden, which takes one upside_down_sensor_dmi_ids[] entry per
> sensor, all sharing the same DMI match but with different ACPI HIDs in
> driver_data.
>
> ipu_bridge_parse_rotation() uses dmi_first_match(), which always stops
> at the first entry matching the running machine, so any further entry
> for the same machine is unreachable and only one sensor per machine can
> ever be corrected.
>
> Walk the whole table and match every entry for the running machine
> against the sensor's ACPI HID instead.
>
> Fixes: b75710155a82 ("media: ipu-bridge: Add DMI quirk for Dell XPS laptops with upside down sensors")
> Signed-off-by: José MarÃa MartÃn <[email protected]>
I'm adding Cc: stable when applying this.
--
Regards,
Sakari Ailus