Re: [PATCH] media: ov5640: select the MIPI lane mode from the endpoint lane count

Sakari Ailus <[email protected]> Tue, 11 Aug 2026 10:22:11 +0300

Newsgroups	org.kernel.vger.linux-media,org.kernel.vger.linux-kernel
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

Hi Jason,

On Tue, Aug 11, 2026 at 03:18:01PM +0800, 楊智成 wrote:
> Hi Sakari,
> 
> Thanks for the review.
> 
> > I guess there wouldn't be harm from backporting either.
> 
> Agreed, switched to a plain stable Cc.
> 
> > How about:
> >
> >         ret = ov5640_write_reg(sensor, OV5640_REG_IO_MIPI_CTRL00,
> >                                on ? 0x5 | ep.bus.mipi_csi2.num_data_lanes << 5 :
> >                                0x40);
> 
> Nicer, thanks - applied, with the lane count in a local variable to
> stay within 80 columns.

There's no need for a local variable, the above remains within 80 columns.

-- 
Sakari Ailus