Re: [PATCH 1/1] media: ipu-bridge: Print SSDB information on debug level

Hi,

On 11-Aug-26 08:16, Sakari Ailus wrote:
> Print information mainly from SSDB: port number, number of lanes, rotation
> and orientation as well as VCM model on debug level.
> 
> Signed-off-by: Sakari Ailus <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans


> ---
>  drivers/media/pci/intel/ipu-bridge.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index 1bb3a3e98d6b..ff3bb80d374e 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -412,6 +412,7 @@ static enum v4l2_fwnode_orientation ipu_bridge_parse_orientation(struct acpi_dev
>  
>  int ipu_bridge_parse_ssdb(struct acpi_device *adev, struct ipu_sensor *sensor)
>  {
> +	acpi_handle handle = acpi_device_handle(ACPI_PTR(adev));
>  	struct ipu_sensor_ssdb ssdb = {};
>  	int ret;
>  
> @@ -435,8 +436,15 @@ int ipu_bridge_parse_ssdb(struct acpi_device *adev, struct ipu_sensor *sensor)
>  	sensor->rotation = ipu_bridge_parse_rotation(adev, &ssdb);
>  	sensor->orientation = ipu_bridge_parse_orientation(adev);
>  
> -	if (ssdb.vcmtype)
> +	acpi_handle_debug(handle,
> +			  "CSI-2 port %u, lanes %u, mclkspeed %u, rotation %u (SSDB %u), orientation %u\n",
> +			  sensor->link, sensor->lanes, sensor->mclkspeed,
> +			  sensor->rotation, ssdb.degree, sensor->orientation);
> +
> +	if (ssdb.vcmtype) {
>  		sensor->vcm_type = ipu_vcm_types[ssdb.vcmtype - 1];
> +		acpi_handle_debug(handle, "VCM %s\n", sensor->vcm_type);
> +	}
>  
>  	return 0;
>  }