Re: [PATCH v2 01/12] dt-bindings: media: qcom,venus: Add context bank subnodes to common schema
Dmitry Baryshkov <[email protected]>
| Newsgroups | org.kernel.vger.linux-media,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <bycv2ktnaeyy54z33ehaqtghh4xze2l7fgsth3lldzsy4jxqat@ywqz5kadz3ie> |
On Thu, Aug 06, 2026 at 05:50:36PM +0530, Vikash Garodia wrote: > > On 8/6/2026 4:44 PM, Dmitry Baryshkov wrote: > > On Thu, Aug 06, 2026 at 11:50:01AM +0100, Bryan O'Donoghue wrote: > > > On 06/08/2026 11:32, Krzysztof Kozlowski wrote: > > > > > Yes -master. > > > > > > > > > > My issue is how long this will take. Several kernel cycles and the > > > > > debate is ongoing. > > > > > > > > > > Daneil's fix has not been applied which means the replicable system bug > > > > > is out there in the wild, not addressed. > > > > > > > > > > Daniel's fix could have been applied and rolled out to all users in > > > > > mainline and consequently stable. > > > > > > > > > > Instead another architectural level fix is still under discussion, which > > > > > is of no value to end users whose systems can reset in the meantime. > > > > > > > > > > Its just not responsible behaviour. So I feel both of these drivers need > > > > > to be marked as BROKEN unless/until a fix lands. > > > > > > > > > > I'm hoping the vidc team will come up with something else. > > > > I did not object taking a known fix for the problem for the mainline > > > > kernel, regardless if the fix is optimal or not. I only objected the > > > > reason of taking patches because of something in stable kernels or > > > > making backports easier or whatever other semi-expressed reason, which > > > > is not the mainline-kernel reason. > > > > > > > > Best regards, > > > > Krzysztof > > > > > > I'm all in favour of rolling out Daniel's fix. > > > > The biggest problem with it is that it looks like a hotfix or a hack > > rather than a proper description / solution. From this PoV we will land > > the fixes for all the boards in mainline and then fix the same issue > > _again_. > > I would call it as un-optimal than a hack, and certainly i can say it would > *not* have to be patched again. Its simple enough that it applies one > reserve region to all, instead of applying it selectively to specific > stream. Exactly. Which means that it doesn't describe the hardware correctly. Which means that it is a band-aid, a hack or something similar rather than being a proper patch. -- With best wishes Dmitry