Re: [PATCH v5] staging: media: atomisp: refactor pipe graph dump stage formatting
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-media,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Tue, Jul 07, 2026 at 09:29:39PM -0700, Neal Patalay wrote: > The original implementation of ia_css_debug_pipe_graph_dump_stage() > includes an off-by-one error where the original strscpy() size drops > characters immediately before newlines. It also allocates over 600 > bytes across multiple buffers on the stack and truncates all output > debug information after three lines. Fix the strscpy() bug, reduce > stack usage with a single 256 byte buffer, and remove the three line > limit via a new helper function, ia_css_debug_build_info(). Reviewed-by: Andy Shevchenko <[email protected]> -- With Best Regards, Andy Shevchenko