Re: [PATCH v2 4/4] staging: media: atomisp: remove include/hmm/hmm_common.h file
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-media,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Thu, Jul 23, 2026 at 09:51:21PM +0300, Nikolay Kulikov wrote:
> Replace the last used macro with a conditional expression and remove
> this header file, as it no longer contains any code that is being used.
Split this to two patches: replace (in the similar way how previous patches
are done) & remove leftovers (file and no more needed includes).
The code wise LGTM, I will give a tag to these patches when they appear in v3
of the series.
...
> + ret = hmm_bo_device_inited(bdev);
> + if (!ret) {
In such a case it's better to have
if (!hmm_bo_device_inited(bdev)) {
> + dev_err(atomisp_dev, "hmm_bo_device not inited yet.\n");
> + return NULL;
> + }
--
With Best Regards,
Andy Shevchenko