Re: [PATCH v2] media: ipu-bridge: Add OV01A1B sensor config

Hi,

On 15-Aug-26 4:23 AM, Steve Kaznak wrote:
> Add the Omnivision OV01A1B (ACPI HID OVTI01AB) to the
> ipu_supported_sensors[] table, with the same single 400 MHz link
> frequency as the OV01A10 and OV01A1S entries it shares a comment with.
> 
> The sensor is the IR camera in the Dell XPS 13 Plus 9320, behind an
> Intel Vision Sensing Controller (IVSC). Commit 36eab90d3f4f ("media:
> i2c: ov01a10: Add ov01a1b support") added driver support for it, but
> without a bridge entry no fwnode graph endpoint is created, so the
> driver never binds and the camera is not enumerated.
> 
> Tested on an XPS 13 Plus 9320: the sensor binds and streams 1296x816
> Y10 at 30 fps.
> 
> Signed-off-by: Steve Kaznak <[email protected]>
> Reviewed-by: Mehdi Djait <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans

> ---
> Changes in v2:
> - Move OVTI01AB before OVTI01AS so the table stays sorted by ACPI HID,
>   and reorder the shared comment to match (Mehdi Djait)
> - Add Reviewed-by from v1
> 
> v1: https://lore.kernel.org/linux-media/[email protected]/
> 
>  drivers/media/pci/intel/ipu-bridge.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index 88581a4c081d..3dde07443002 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -73,8 +73,9 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = {
>  	IPU_SENSOR_CONFIG("INT3537", 1, 437000000),
>  	/* Lontium lt6911uxe */
>  	IPU_SENSOR_CONFIG("INTC10C5", 0),
> -	/* Omnivision OV01A10 / OV01A1S */
> +	/* Omnivision OV01A10 / OV01A1B / OV01A1S */
>  	IPU_SENSOR_CONFIG("OVTI01A0", 1, 400000000),
> +	IPU_SENSOR_CONFIG("OVTI01AB", 1, 400000000),
>  	IPU_SENSOR_CONFIG("OVTI01AS", 1, 400000000),
>  	/* Omnivision OV02C10 */
>  	IPU_SENSOR_CONFIG("OVTI02C1", 1, 400000000),