Re: [PATCH 5.10] media: mtk-vcodec: potential null pointer deference in SCP
Sasha Levin <[email protected]>
| Newsgroups | org.kernel.vger.linux-media,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
> fw = devm_kzalloc(&dev->plat_dev->dev, sizeof(*fw), GFP_KERNEL);
> + if (!fw)
> + return ERR_PTR(-ENOMEM);
The backport itself is faithful, but the error path it adds returns
without dropping the scp reference taken just above it. That leak is
fixed upstream by 4936cd5817af ("media: mediatek: vcodec: Fix a resource
leak related to the scp device in FW initialization") (Fixes:
53dbe0850444, Cc: stable), and every tree carrying 53dbe0850444 already
carries the follow-up as well - taking this one alone would leave 5.10 as
the only stable tree in the leaky state.
Could you resend it as a 2-patch series covering both commits, targeting
5.15 as well as 5.10? 5.15 is missing both and holds the file at the same
path with an identical blob, so the same two patches apply there
unchanged.
--
Thanks,
Sasha