Re: [RESEND PATCH 0/5] Add driver for Broadcom FacetimeHD camera

Yes, merging the PRs is probably a good idea. On the firmware, I only
included the install script since it doesn't require a manual
download, but including the extraction script as well isn't be a
problem.
Can you message me (or submit a patch set) when the driver is ready
for upstreaming?

Thanks,
Jack


On Thu, Aug 20, 2026 at 12:37 PM Patrik Jakobsson
<[email protected]> wrote:
>
> On Thu, Aug 20, 2026 at 8:22 PM Jack Flusche <[email protected]> wrote:
> >
> > Merge Patrik Jakobsson's out-of-tree driver for the Broadcom FacetimeHD
> > camera on some Apple Macbooks using the Video4Linux 2 framework to add
> > in-tree support and remove the need to install a DKMS package
>
> Hi Jack,
> I'm fine with upstreaming this but here are some initial thoughts:
> - Should this be in staging instead? I defer that question to the
> media maintainers.
> - There are quite a few PRs pending on github. Perhaps I should merge
> them first and then we redo the submission with those included?
> - Perhaps we should have both the download and extraction scripts
> included? We've just updated the download script to grab a much newer
> version which adds support for new devices.
>
> Thanks
> Patrik
>
> >
> > Jack Flusche (5):
> >   facetimehd: copy code from patjak/facetimehd
> >   facetimehd: add Kconfig and Makefile
> >   facetimehd: fix compile-time issues and formatting
> >   facetimehd: add firmware extraction script from
> >     patjak/facetimehd-firmware
> >   facetimehd: add entry to MAINTAINERS
> >
> >  MAINTAINERS                                 |    7 +
> >  drivers/media/pci/Kconfig                   |    1 +
> >  drivers/media/pci/Makefile                  |    1 +
> >  drivers/media/pci/facetimehd/FIRMWARE       |    6 +
> >  drivers/media/pci/facetimehd/Kconfig        |   12 +
> >  drivers/media/pci/facetimehd/Makefile       |    2 +
> >  drivers/media/pci/facetimehd/firmware.sh    |   61 +
> >  drivers/media/pci/facetimehd/fthd_buffer.c  |  126 ++
> >  drivers/media/pci/facetimehd/fthd_buffer.h  |   73 +
> >  drivers/media/pci/facetimehd/fthd_ddr.c     |  670 +++++++++
> >  drivers/media/pci/facetimehd/fthd_ddr.h     |   33 +
> >  drivers/media/pci/facetimehd/fthd_debugfs.c |  204 +++
> >  drivers/media/pci/facetimehd/fthd_debugfs.h |   16 +
> >  drivers/media/pci/facetimehd/fthd_drv.c     |  558 +++++++
> >  drivers/media/pci/facetimehd/fthd_drv.h     |  124 ++
> >  drivers/media/pci/facetimehd/fthd_hw.c      |  710 +++++++++
> >  drivers/media/pci/facetimehd/fthd_hw.h      |  128 ++
> >  drivers/media/pci/facetimehd/fthd_isp.c     | 1468 +++++++++++++++++++
> >  drivers/media/pci/facetimehd/fthd_isp.h     |  770 ++++++++++
> >  drivers/media/pci/facetimehd/fthd_reg.h     |  183 +++
> >  drivers/media/pci/facetimehd/fthd_ringbuf.c |  133 ++
> >  drivers/media/pci/facetimehd/fthd_ringbuf.h |   45 +
> >  drivers/media/pci/facetimehd/fthd_v4l2.c    |  759 ++++++++++
> >  drivers/media/pci/facetimehd/fthd_v4l2.h    |   34 +
> >  24 files changed, 6124 insertions(+)
> >  create mode 100644 drivers/media/pci/facetimehd/FIRMWARE
> >  create mode 100644 drivers/media/pci/facetimehd/Kconfig
> >  create mode 100644 drivers/media/pci/facetimehd/Makefile
> >  create mode 100755 drivers/media/pci/facetimehd/firmware.sh
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_buffer.c
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_buffer.h
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_ddr.c
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_ddr.h
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_debugfs.c
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_debugfs.h
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_drv.c
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_drv.h
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_hw.c
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_hw.h
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_isp.c
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_isp.h
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_reg.h
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_ringbuf.c
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_ringbuf.h
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_v4l2.c
> >  create mode 100644 drivers/media/pci/facetimehd/fthd_v4l2.h
> >
> > --
> > 2.55.0
> >