Re: [PATCH v3 11/29] media: rzg2l-cru: Use v4l2_subdev_get_frame_desc_passthrough_csi2()

On Mon, Aug 24, 2026 at 03:14:33PM +0300, Sakari Ailus wrote:
> Switch to v4l2_subdev_get_frame_desc_passthrough_csi2() in order to set
> the frame descriptor type in the get_frame_desc() callback.
>
> Signed-off-by: Sakari Ailus <[email protected]>
> ---

Reviewed-by: Frank Li <[email protected]>

>  .../platform/renesas/rzg2l-cru/rzg2l-csi2.c   | 21 +------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> index 6dc4b53607b4..472154c5ca9e 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> @@ -722,25 +722,6 @@ static int rzg2l_csi2_enum_frame_size(struct v4l2_subdev *sd,
>  	return 0;
>  }
>
> -static int rzg2l_csi2_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
> -				     struct v4l2_mbus_frame_desc *fd)
> -{
> -	struct rzg2l_csi2 *csi2 = sd_to_csi2(sd);
> -	struct media_pad *remote_pad;
> -
> -	if (!csi2->remote_source)
> -		return -ENODEV;
> -
> -	remote_pad = media_pad_remote_pad_unique(&csi2->pads[RZG2L_CSI2_SINK]);
> -	if (IS_ERR(remote_pad)) {
> -		dev_err(csi2->dev, "can't get source pad of %s (%pe)\n",
> -			csi2->remote_source->name, remote_pad);
> -		return PTR_ERR(remote_pad);
> -	}
> -	return v4l2_subdev_call(csi2->remote_source, pad, get_frame_desc,
> -				remote_pad->index, fd);
> -}
> -
>  static const struct v4l2_subdev_video_ops rzg2l_csi2_video_ops = {
>  	.s_stream = rzg2l_csi2_s_stream,
>  	.pre_streamon = rzg2l_csi2_pre_streamon,
> @@ -752,7 +733,7 @@ static const struct v4l2_subdev_pad_ops rzg2l_csi2_pad_ops = {
>  	.enum_frame_size = rzg2l_csi2_enum_frame_size,
>  	.set_fmt = rzg2l_csi2_set_format,
>  	.get_fmt = v4l2_subdev_get_fmt,
> -	.get_frame_desc = rzg2l_csi2_get_frame_desc,
> +	.get_frame_desc = v4l2_subdev_get_frame_desc_passthrough_csi2,
>  };
>
>  static const struct v4l2_subdev_ops rzg2l_csi2_subdev_ops = {
> --
> 2.47.3
>