Re: [PATCH v1] MIPS: ip22-gio: Drop #include of <linux/mod_devicetable.h>

On Fri, Jul 10, 2026 at 10:24:12AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> That header doesn't use any device id provided by
> <linux/mod_devicetable.h>. Also the users of <asm/gio_device.h> (i.e.
> arch/mips/sgi-ip22/ip22-gio.c and drivers/video/console/newport_con.c)
> don't use any of them and they compile fine in a mips allmodconfig.
> 
> So drop the unused include that only yields unnecessary recompilations
> when a device id struct changes.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>
> ---
>  arch/mips/include/asm/gio_device.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/gio_device.h b/arch/mips/include/asm/gio_device.h
> index f9c102f038d6..6e9d2897347d 100644
> --- a/arch/mips/include/asm/gio_device.h
> +++ b/arch/mips/include/asm/gio_device.h
> @@ -1,6 +1,5 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  #include <linux/device.h>
> -#include <linux/mod_devicetable.h>
>  
>  struct gio_device_id {
>  	__u8 id;
> 
> base-commit: 34cf6dafc47441dfb6b356a095b89c3585a93714
> -- 
> 2.55.0.11.g153666a7d9bb

applied to mips-next

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]