Re: [PATCH v1 3/7] media: em28xx: Open code gpio_request_one()
Hans Verkuil <[email protected]> Mon, 27 Jul 2026 11:53:13 +0200
| Newsgroups | org.kernel.vger.linux-mips,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-doc,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <[email protected]> |
On 15/07/2026 20:46, Andy Shevchenko wrote: > Open code the gpio_request_one() call to be able to kill that API > in the follow changes. > > Signed-off-by: Andy Shevchenko <[email protected]> Acked-by: Hans Verkuil <[email protected]> Regards, Hans > --- > drivers/media/usb/em28xx/em28xx-dvb.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c > index ef148a27c94d..d7f8dcf27900 100644 > --- a/drivers/media/usb/em28xx/em28xx-dvb.c > +++ b/drivers/media/usb/em28xx/em28xx-dvb.c > @@ -742,18 +742,14 @@ static int em28xx_pctv_290e_set_lna_gpio(struct em28xx *dev, u32 lna) > #ifdef CONFIG_GPIOLIB_LEGACY > struct em28xx_dvb *dvb = dev->dvb; > int ret; > - unsigned long flags; > > - if (lna == 1) > - flags = GPIOF_OUT_INIT_HIGH; /* enable LNA */ > - else > - flags = GPIOF_OUT_INIT_LOW; /* disable LNA */ > - > - ret = gpio_request_one(dvb->lna_gpio, flags, NULL); > - if (ret) > + ret = gpio_request(dvb->lna_gpio, NULL); > + if (ret) { > dev_err(&dev->intf->dev, "gpio request failed %d\n", ret); > - else > + } else { > + gpio_direction_output(dvb->lna_gpio, !!(lna == 1)); > gpio_free(dvb->lna_gpio); > + } > > return ret; > #else