Re: [PATCH v2] i2c: jz4780: Cache host clock rate at probe to prevent CCF prepare_lock deadlock
"H. Nikolaus Schaller" <[email protected]> Fri, 31 Jul 2026 08:04:45 +0200
| Newsgroups | org.kernel.vger.linux-mips,org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
Hi Andi, > Am 27.07.2026 um 22:59 schrieb Andi Shyti <[email protected]>: >=20 > Hi Nikolaus, >=20 >> Fixes: ba92222ed63a12 ("i2c: jz4780: Add i2c bus controller driver = for Ingenic JZ4780") >> Cc: [email protected] >> Signed-off-by: H. Nikolaus Schaller <[email protected]> >=20 > To be clear, I wasn't against the patch itself, I just didn't > like the commit log and I raised questions coming just from > reading the log. Sorry that I did not get this because I could not see a question. > In this v2 you are missing the changelog, please, don't forget > next time to add it. That is the downside of too much automation on our side. It did not properly catch the case of a single patch without cover letter. So the changelog is in the suppressed cover letter... Here for the records: PATCH V2 2026-07-19 22:19:42: Changes: 1) improved the commit message to clearly separate between i2c host = clock rate and the clock rate of the clock generator which is controlled = through i2c Suggested-by: [email protected] 2a) changed to clk_rate_khz (and moved the division by 1000 to probe) 2b) fixed the variable type and name definition (wrong spacing/tabs) Suggested-by: [email protected] PATCH V1 2026-07-10 08:58:35: initial version. >=20 > I merged your patch in i2c/i2c-fixes. Thank you very much. BR, Nikolaus